Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse escaped colons in class names correctly #458

Merged
merged 2 commits into from
May 19, 2023
Merged

Parse escaped colons in class names correctly #458

merged 2 commits into from
May 19, 2023

Conversation

viniciusmuller
Copy link
Contributor

This pull requests adds an extra rule in the parser in order to prevent escaped class names (a.xs\\:red-500) from being parsed as pseudo selectors.

Closes #411

@philss philss merged commit 46e8cc8 into philss:main May 19, 2023
@philss
Copy link
Owner

philss commented May 19, 2023

@viniciusmuller thank you!! 💜

@philss philss mentioned this pull request May 29, 2023
Closed
philss added a commit that referenced this pull request Jun 2, 2023
@philss
Fix class selector with colon
2641a67 
This is related to the following:

#458
#411

I decided to push the "cleaning" to the lexer, but I think
for more complex escaping rules, we may need to push back to
Elixir.
@philss philss mentioned this pull request Jun 2, 2023
Merged
philss added a commit that referenced this pull request Jun 2, 2023
@philss
Fix class selector with colon (#464)
ac13707 
This is related to the following:

#458
#411

I decided to push the "cleaning" to the lexer, but I think
for more complex escaping rules, we may need to push back to
Elixir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philss philss philss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floki.find doesn't support escaped colons in class names
2 participants
@viniciusmuller @philss