Add include_inputs? option to Floki.text
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philss
reviewed
May 22, 2023
There was a problem hiding this comment.
Hey @viniciusmuller 👋
Thank you for the PR! 💜 I added some comments to it.
But overall it looks good!
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com>
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com>
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
include_inputs?option to theFloki.textfunction.Example usage:
Currently it will add into the resulting text all the values from a list of allowed inputs (excluding things such as checkboxes and radios)
Feel free to review and point any changes you would like @philss
Closes #391