Run all selector test with tuple list and html tree #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure we don't have any regression on the changes for #515, we need to run all selector tests with both html node tuple list and with HTMLTree.
This PR modifies most asserts on Floki.find to use
assert_find, which will check the results of Floki.find with an html node tuple list, and then check if the result is the same when calling Floki.Finder.find with an HTMLTree.On tests that have to use pattern matching instead of equals, the comparison is done directly in the test instead of using
assert_find.Depends on #522