Find using descendant selector without html tree #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the new optimized find when the selector contains only descendant selector. The performance improvement on this one is even higher than in the previous PR, and is pretty close to a find using a selector without descendant.
For descendant selector the html tree traversal ends up traversing the same element multiple times. In this traverse we'll check each element only once.
This happens because this traverse doesn't add all element upfront with the initial selector, and instead add each children as we navigate the stack. On a match, we can add the children items with the combinator selector directly, which avoids traversing this element twice and avoids duplicating the element in the result, which we are not able to dedup on this find.