Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileUtils] Fixed file separator/pathSeparator as not always set. #1318

Merged
merged 11 commits into from
Apr 18, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 18, 2020

Removed buggy code.

@siad007 siad007 changed the title [core] Cleanup code [FileUtils] Fixed file separator/pathSeparator as not always set. Apr 18, 2020
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Apr 18, 2020
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #1318 into master will increase coverage by 0.01%.
The diff coverage is 76.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1318      +/-   ##
============================================
+ Coverage     51.64%   51.65%   +0.01%     
- Complexity     9277     9278       +1     
============================================
  Files           477      477              
  Lines         22655    22658       +3     
============================================
+ Hits          11701    11705       +4     
+ Misses        10954    10953       -1     
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/property/PathToFileSet.php 0.00% <0.00%> (ø) 18.00 <0.00> (ø)
classes/phing/tasks/system/ApplyTask.php 70.10% <40.00%> (ø) 102.00 <0.00> (ø)
classes/phing/util/FileUtils.php 70.76% <75.00%> (+1.11%) 84.00 <4.00> (+1.00)
classes/phing/Phing.php 37.03% <100.00%> (ø) 229.00 <0.00> (ø)
classes/phing/mappers/CutDirsMapper.php 92.85% <100.00%> (ø) 7.00 <0.00> (ø)
classes/phing/system/io/PhingFile.php 83.24% <100.00%> (ø) 92.00 <0.00> (ø)
classes/phing/tasks/system/PathConvert.php 61.15% <100.00%> (ø) 48.00 <0.00> (ø)
classes/phing/types/Commandline.php 85.81% <100.00%> (ø) 65.00 <0.00> (ø)
classes/phing/util/DirectoryScanner.php 68.44% <100.00%> (ø) 101.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb4644...5b8da19. Read the comment docs.

@siad007 siad007 merged commit 77c655d into master Apr 18, 2020
@siad007 siad007 deleted the siad007-patch-2 branch April 18, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant