Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClassConstants filter #1322

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 24, 2020

Assembles the constants declared in a PHP class in

key1=value1
key2=value2

format.
Example usage:

class Foo
{
    public const CONST1 = 'CONST 1';
    protected const CONST2 = 'CONST 2';
    private const CONST3 = 'CONST 3';
}
<property file="constants.php">
    <filterchain>
      <classconstants />
    </filterchain>
</property>
<echo msg"${CONST1}"/>
<echo msg"${CONST2}"/>
<echo msg"${CONST3}"/>

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #1322 into master will increase coverage by 0.04%.
The diff coverage is 96.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1322      +/-   ##
============================================
+ Coverage     51.79%   51.84%   +0.04%     
- Complexity     9245     9255      +10     
============================================
  Files           474      475       +1     
  Lines         22593    22618      +25     
============================================
+ Hits          11703    11727      +24     
- Misses        10890    10891       +1     
Impacted Files Coverage Δ Complexity Δ
classes/phing/filters/ClassConstants.php 93.33% <93.33%> (ø) 5.00 <5.00> (?)
classes/phing/tasks/system/PropertyTask.php 81.00% <100.00%> (+0.88%) 80.00 <0.00> (+4.00)
classes/phing/types/FilterChain.php 52.85% <100.00%> (+1.38%) 33.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5d4dc...732f1d4. Read the comment docs.

siad007 added a commit to phingofficial/guide that referenced this pull request Apr 25, 2020
@siad007 siad007 merged commit d68b8d8 into phingofficial:master Apr 25, 2020
@siad007 siad007 deleted the ClassConstantsFilter branch April 25, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant