Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Code cleanup on test files #1570

Merged
merged 6 commits into from
Apr 1, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 1, 2021

No description provided.

@siad007 siad007 added core cleanup code cleanup labels Apr 1, 2021
@siad007 siad007 added this to the 3.0.0-RC2 milestone Apr 1, 2021
@siad007 siad007 self-assigned this Apr 1, 2021
@siad007 siad007 changed the title Code cleanup on test files [core] Code cleanup on test files Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1570 (85a18c3) into main (edb315f) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 85a18c3 differs from pull request most recent head 4c0d917. Consider uploading reports for the commit 4c0d917 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1570      +/-   ##
============================================
- Coverage     55.98%   55.95%   -0.03%     
  Complexity     6909     6909              
============================================
  Files           354      354              
  Lines         16723    16723              
============================================
- Hits           9362     9357       -5     
- Misses         7361     7366       +5     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Io/SourceFileScanner.php 67.64% <0.00%> (-7.36%) 21.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb315f...4c0d917. Read the comment docs.

@siad007 siad007 added scrutinizer fixed scrutinizer issue and removed work in progress labels Apr 1, 2021
@siad007 siad007 merged commit b4ea7c0 into phingofficial:main Apr 1, 2021
@siad007 siad007 deleted the TestCleanup branch April 1, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core scrutinizer fixed scrutinizer issue
Development

Successfully merging this pull request may close these issues.

1 participant