Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrutinizer issue fixes #1577

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 5, 2021

No description provided.

@siad007 siad007 added core scrutinizer fixed scrutinizer issue labels Apr 5, 2021
@siad007 siad007 added this to the 3.0.0-RC2 milestone Apr 5, 2021
@siad007 siad007 self-assigned this Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1577 (1e78d0e) into main (966a829) will decrease coverage by 0.00%.
The diff coverage is 78.94%.

❗ Current head 1e78d0e differs from pull request most recent head 8ccfb31. Consider uploading reports for the commit 8ccfb31 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1577      +/-   ##
============================================
- Coverage     56.16%   56.16%   -0.01%     
  Complexity     6917     6917              
============================================
  Files           354      354              
  Lines         16752    16751       -1     
============================================
- Hits           9409     9408       -1     
  Misses         7343     7343              
Impacted Files Coverage Δ Complexity Δ
src/Phing/PropertyHelper.php 82.63% <78.94%> (-0.11%) 67.00 <67.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966a829...8ccfb31. Read the comment docs.

@siad007 siad007 merged commit 5d15cfe into phingofficial:main Apr 5, 2021
@siad007 siad007 deleted the scrutinizer-fixes-2 branch April 5, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core scrutinizer fixed scrutinizer issue
Development

Successfully merging this pull request may close these issues.

1 participant