Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#946: Trim outputProperty value of GitLogTask. #947

Merged
merged 2 commits into from
Jul 26, 2018
Merged

#946: Trim outputProperty value of GitLogTask. #947

merged 2 commits into from
Jul 26, 2018

Conversation

kenguest
Copy link
Member

Fix issue with string coming back from executing the git log command not being trimmed.

siad007
siad007 approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

siad007
siad007 requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind solving the failing test? Did not see it before.

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Jul 26, 2018
@siad007 siad007 added the defect label Jul 26, 2018
@siad007 siad007 merged commit 92e85b7 into phingofficial:master Jul 26, 2018
@codecov
Copy link

codecov bot commented Jul 26, 2018 •
edited
Loading

Codecov Report

Merging #947 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #947   +/-   ##
========================================
  Coverage      44.9%   44.9%           
  Complexity     9920    9920           
========================================
  Files           499     499           
  Lines         24044   24044           
========================================
  Hits          10796   10796           
  Misses        13248   13248
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/git/GitLogTask.php 93.67% <100%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2af7ce...e1345fb. Read the comment docs.

@kenguest kenguest mentioned this pull request Jul 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siad007 siad007 siad007 approved these changes

Assignees
No one assigned
Labels
defect
Milestone
3.0.0-alpha2
Development

Successfully merging this pull request may close these issues.
2 participants
@kenguest @siad007