Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbosity to VersionTask #967

Merged
merged 2 commits into from
Oct 7, 2018

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Oct 7, 2018

Using VersionTask is not so obvious at the beginning, so I added some log messages. I also did a small code refactoring.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawira Thanks for your PR but there is at least one failing test. Would you mind have a look at
/home/travis/build/phingofficial/phing/test/build.xml:80:25 Test FAILURE (testPropFileWithDefaultProperty in class VersionTaskTest): property build.version
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'4.5.5'
+'0.0.1'

@jawira jawira force-pushed the feature/add-version-verbosity branch from d807cc5 to 1402551 Compare October 7, 2018 16:43
@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #967 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #967      +/-   ##
============================================
- Coverage     44.88%   44.87%   -0.02%     
  Complexity     9921     9921              
============================================
  Files           499      499              
  Lines         24046    24049       +3     
============================================
- Hits          10793    10791       -2     
- Misses        13253    13258       +5
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/VersionTask.php 79.06% <100%> (+0.75%) 27 <3> (ø) ⬇️
classes/phing/util/SourceFileScanner.php 63.76% <0%> (-7.25%) 21% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0347067...602baa2. Read the comment docs.

@jawira
Copy link
Contributor Author

jawira commented Oct 7, 2018

Yep, I fixed the bug :)

@siad007 siad007 merged commit fdca258 into phingofficial:master Oct 7, 2018
@jawira jawira deleted the feature/add-version-verbosity branch October 7, 2018 17:01
@mrook mrook added this to the 3.0.0-alpha2 milestone Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants