Avoid calling get_class on null in UnknownElement.

[elyobo]

Explicitly passing NULL to get_class triggers E_WARNING as of PHP 7.2[1].

[1] https://secure.php.net/get_class

[codecov]

Codecov Report

Merging #972 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #972   +/-   ##
========================================
  Coverage      44.9%   44.9%           
- Complexity     9924    9925    +1     
========================================
  Files           499     499           
  Lines         24053   24053           
========================================
  Hits          10800   10800           
  Misses        13253   13253

Impacted Files	Coverage Δ	Complexity Δ
classes/phing/UnknownElement.php	94.2% <100%> (ø)	28 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317ac90...8202982. Read the comment docs.

[siad007]

Would you mind to format your code according to PSR-2 please.

[elyobo]

@siad007 I'd be happy to, but you'll have to be more clear - as far as I can see it's already compliant with the requirements for ternaries, was there something else you were referring to?

[siad007]

@elyobo https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#25-keywords-and-truefalsenull

[elyobo]

Thanks, fixed and squashed.

If you're inclined to merge this, can we also merge it back as a fix on to the 2.x series?

[siad007]

@elyobo

If you're inclined to merge this, can we also merge it back as a fix on to the 2.x series?

it does not make sence for the 2.x branch as well - exept @mrook is willing to make it happen.
For php > 7 the actual 3.x is the way to go in my opinion.

thx for contributing.

[elyobo]

Fair enough; I haven't looked at whatever changes are upcoming in 3.x, but given the major version change I was assuming backwards incompatibility. The fix is trivial so hopefully @mrook is amenable to applying it to the current release branch as well as the alpha version.

…

On Sun, 21 Oct 2018, 10:14 Siad Ardroumli, ***@***.***> wrote: @elyobo <https://github.com/elyobo> If you're inclined to merge this, can we also merge it back as a fix on to the 2.x series? it does not make sence for the 2.x branch as well exept @mrook <https://github.com/mrook> is willing to make it happen. For php > 7 the actual 3.x is the way to go in my opinion. thx for contributing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#972 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAY4_s4pg3uaiHun4mjYZl1D036QZv3Iks5um65ngaJpZM4XmXX6> .

[elyobo]

Coming up on a year later, v3 is still alpha, and this still bites me periodically. Any interest in applying this trivial fix to improve PHP7 compatibility @mrook @siad007?

[mrook]

I think I missed this. I'll take a look at rolling a 2.16.x patch fix with this applied. We don't have any definitive plans for the v3 release roadmap.

[elyobo]

👍 Thanks