cli: improve error message on expired token #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly improve the error message when an expired token is used. Old experience:
thread 'main' panicked at src/fetch.rs:95:10:
called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Decode, source: Error("missing field `data`", line: 1, column: 40) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
New experience:
thread 'main' panicked at src/fetch.rs:98:13:
Request to Gitlab failed: HTTP status client error (401 Unauthorized) for url (https://gitlab.vpn.cyberus-technology.de/api/graphql)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
It's not perfect and a better solution would be proper error handling
with anyhow. But this would have already poked me in the right
direction.
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improve the error message when an expired token is used. Old experience:
New experience:
It's not perfect, and a better solution would be proper error handling with anyhow. But this error message would have already poked me in the right direction.