Lightweight Flake #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmh. It seems I broke MacOS. Is there a good way to test it? |
phip1611
reviewed
Aug 13, 2024
| [profile.release] | ||
| codegen-units = 1 | ||
| opt-level = "s" | ||
| lto = true |
There was a problem hiding this comment.
Removing LTO from the build options cuts build times in half for no apparent downside.
Here are my measurements:
- 1.82.0-nightly + existing codegen options : 20,91s
- 1.82.0-nightly + default codegen options : 11,39s
- 1.80.1 (stable) + existing codegen options: 20,77s
- 1.80.1 (stable) + default codegen options : 11.85s
I agree that there is a benefit. Further, I verified that opt-level = "s" only saves 300K, although not impacting build times. As the micro optimization really isn't that important and it apparently solves problems for you, I'm fine with the changes.
phip1611
approved these changes
Aug 13, 2024
The Rust overlay is very large, because it carries information about all possible Rust toolchain versions. This is sometimes useful, but this tool builds fine with the Rust version in Nixpkgs. This change reduces the stuff that users have to download quite a bit. Not only is there now rust-overlay tarball to download, you also use the default Rust toolchain, which is probably already somewhere on disk!
There is no need to micro-optimize the binary. Removing LTO from the build options cuts build times in half for no apparent downside. I've also removed the strippping, because the Cargo manual advices against it for proper backtraces.
The MacOS build fails with: > ++ command cargo build --release --message-format json-render-diagnostics --locked > Compiling gitlab-timelogs v0.2.2 (/private/tmp/nix-build-gitlab-timelogs-0.2.2.drv-0/8bm81sjfqmsk7lclw7pnddrxv785aaj3-source) > error: linking with `cc` failed: exit status: 1 Fix by manually adding iconv as a dependency. Other people also have encountered this: nix-community/home-manager#3482
phip1611
force-pushed
the
lightweight-flake
branch
from
819117d to
f7c665e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to make the flake more lightweight. 🪶
rust-overlaybecause the default Rust toolchain is good enough andrust-overlayis large.Please take a look at the commit messages for more information.