Static components #20
Conversation
| def to_s | ||
| "#\{#{@value}}" | ||
| end |
There was a problem hiding this comment.
Shouldn't use to_s here as it blocks us from recording to_s calls.
| end | ||
|
|
||
| def method_missing(method_name, *args) | ||
| @value << "." << method_name.name |
There was a problem hiding this comment.
The "." here should be a constant frozen string.
There was a problem hiding this comment.
More to this, is string interpolation a bit faster than << ?
There was a problem hiding this comment.
I think it's pretty negligible, but in theory interpolation should be slightly faster, yes.
There was a problem hiding this comment.
Yeah, and no need to frozen string
There was a problem hiding this comment.
| def initialize(**kwargs) | ||
| kwargs.keys.each do |
There was a problem hiding this comment.
| def initialize(**kwargs) | |
| kwargs.keys.each do | |
| def initialize(**assigns) | |
| assigns.keys.each do |
| (klass.instance_methods - StaticComponent.instance_methods).each do |m| | ||
| klass.define_method(m) { CallChainCollector.new(m) } | ||
| end |
There was a problem hiding this comment.
There's got to be a better way to do this.
| end | ||
|
|
||
| def content(&) | ||
| raw '#{content(&)}' |
There was a problem hiding this comment.
raw needs implementing. It might be worth calling it something else to indicate that it shouldn't be used. Maybe just _raw or _raw_i_know_what_im_doing!!!!!!!!.
| class StaticComponent < Component | ||
| def call | ||
| return super if is_a? Compiler | ||
| if respond_to? :compiled_template |
There was a problem hiding this comment.
We need a faster way to detect if a compiled template already exists. I think respond_to? is quite slow because it needs to look through the ancestry.
There was a problem hiding this comment.
Maybe set instance variable once compiled_template is called ?
There was a problem hiding this comment.
Yep, that's what I’m thinking. It’d be faster to check the instance variable.
| end | ||
|
|
||
| def compile_template | ||
| compiler_class = Class.new(self.class).include(Compiler) |
There was a problem hiding this comment.
Is Compiler getting included at runtime ?
There was a problem hiding this comment.
Yes. The only way to execute the template method against a new object is to subclass the component with that method, so the technique here is to subclass the component as an anonymous class and then include the Compiler functionality required to mock out the instance variables and methods.
I wish there was a way to instance_exec a bound method, e.g. method(:template) against another object like you can a block, but that doesn't seem possible.
There was a problem hiding this comment.
Hmm ok, but didn't exactly get why Compiler can not be included at compile time. I'm thinking how much it can impact runtime processing for multiple instances otherwise 🤔
There was a problem hiding this comment.
There isn't a compile time in Ruby, but we could definitely run the compilations on boot. At this point though, it's very unlikely I’ll merge this PR. I’m working on a new compiler that will be able to capture logic as well as markup strings.
This was totally worth building though as it proved it would work and showed how much faster compiled templates could be. Here's a benchmark I ran rendering 100k components.
There was a problem hiding this comment.
Ah yeah, I meant on boot time. Benchmark looks great!!
|
I’m going to close this in favour of #19. It was worth prototyping something, but I don't think this is the right solution. |
Here's a rudimentary implementation of static components. Essentially, we render the component in the context of an object that returns interpolation strings for anything that's called on it.
I don't know if it's worth merging this or holding off and building something with syntax tree.
Closes #19