Refresh Code base #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, are GitHub Actions disabled in this repository? The pull_request event should trigger the new action here. The push action worked in my fork https://github.com/rieschl/PhlyBlog/actions |
rieschl
commented
Oct 11, 2020
composer.json
Outdated
| "laminas/laminas-uri": "^2.5", | ||
| "laminas/laminas-validator": "^2.5", | ||
| "laminas/laminas-view": "^2.5", | ||
| "phly/phly-common": "dev-refresh" |
There was a problem hiding this comment.
This line and the repositories block will be removed after PhlyCommon was merged and tagged.
rieschl
commented
Oct 11, 2020
| "require": { | ||
| "phly/phly-blog": "dev-master" | ||
| "phly/phly-blog": "^3.0" |
There was a problem hiding this comment.
It'll be tagged as 3.0.0, right?
There was a problem hiding this comment.
I never did a 2.0, so this would be 2.0 here. :)
|
@rieschl and @weierophinney this looks good to me. 💯 |
* migrate to Laminas * fix test namespace * (mostly) apply Laminas Coding Standard * add GitHub Action
* use iteratorToArray from StdLib * correctly detach event listeners * fix call to ServiceManager in Controller
|
@rieschl Actions have to be present in the default branch in order to run, IIRC. |
weierophinney
force-pushed
the
refresh
branch
from
1158faf to
ca4d1cc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this is a very very big PR. Normally I don't do that because reviewing is quite hard that way, but the code base is very old and probably has a low usage, it's much easier than separate PRs.
But the commits are somewhat divided: the first one is the big one with Laminas, code style and code quality changes and the upgrade from mvc and eventmanager v2 to v3 is in a separate commit. The commits after that are bug fixes and forgotten stuff.
Edit: ... and I tested it on a freshly installed laminas-mvc skeleton 🙂
fixes #15