Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DapperRepository methods add CancellationToken override. #208

Merged
merged 1 commit into from
Apr 28, 2022
Merged

DapperRepository methods add CancellationToken override. #208

merged 1 commit into from
Apr 28, 2022

Conversation

pengweiqhca
Copy link
Contributor

@pengweiqhca pengweiqhca commented Apr 28, 2022 •
edited
Loading

Fix #207.

Generate code with t4.

@pengweiqhca pengweiqhca requested a review from phnx47 as a code owner April 28, 2022 07:07
@pengweiqhca pengweiqhca changed the title IDapperRepository and IReadOnlyDapperRepository method add Cancellati… IDapperRepository method add CancellationToken override. Apr 28, 2022
@pengweiqhca pengweiqhca changed the title IDapperRepository method add CancellationToken override. DapperRepository method add CancellationToken override. Apr 28, 2022
@pengweiqhca pengweiqhca changed the title DapperRepository method add CancellationToken override. DapperRepository methods add CancellationToken override. Apr 28, 2022
@phnx47 phnx47 merged commit 707d38f into phnx47:master Apr 28, 2022
@phnx47
Copy link
Owner

phnx47 commented Apr 28, 2022 •
edited
Loading

@pengweiqhca Hi, I merged it and later see that you add tt and generated files. Can you remove these templates, clean up and raise PR again? Just Cancellation token, without t4 templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phnx47 phnx47 phnx47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DapperRepository method missing CancellationToken override.
2 participants
@pengweiqhca @phnx47