Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce generic image_builder #1169

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Introduce generic image_builder #1169

merged 3 commits into from
Oct 1, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Sep 19, 2024

Description

Introduce python-based image builder (plo scripts parsing/generation). Main features:

  • single nvm.yaml to describe all Non-Volatile Memory storage in a project
  • plo scripts as YAML files with jinja2 templates (only values)
  • use internal Elf parser for kernelimg command
  • fix some of the incremental build errors, describe some of the project decisions better

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
    Building: add new dependencies phoenix-rtos-doc#212
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie nalajcie marked this pull request as draft September 19, 2024 12:20
@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch 2 times, most recently from 3550262 to 1775200 Compare September 19, 2024 12:35
Copy link

github-actions bot commented Sep 19, 2024

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   36m 54s ⏱️ -29s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8474a0e. ± Comparison against base commit bacc9cd.

♻️ This comment has been updated with latest results.

@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch 14 times, most recently from ae023f2 to 11838e1 Compare September 25, 2024 10:58
@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch 2 times, most recently from c0a2cd8 to c467e1f Compare September 30, 2024 14:14
@nalajcie nalajcie changed the title (WIP) Introduce generic image_builder Introduce generic image_builder Sep 30, 2024
@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch 2 times, most recently from af3880c to 05cbdf8 Compare September 30, 2024 15:58
@nalajcie nalajcie marked this pull request as ready for review October 1, 2024 09:36
@nalajcie nalajcie merged commit 03c05cc into master Oct 1, 2024
34 checks passed
@nalajcie nalajcie deleted the nalajcie/new_plo_scripts branch October 1, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant