performance refactoring for calendar views #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+show/hide filter options
+show/hide filter options
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calendar events have an icon to indicate conflicts (ie. staff assigned while on vacation). a new filter tickbox is added which allows to disable calculating the conflicts for a better load times.
furthermore, recent profiling turned out that redundant (re-)loading details of displayed events are another reason for slow loading times, especially with lots of events visible. this caused a high frequency of unneccesary service method invocations, which can be avoided.
with this fix, load times of month views with hundreds of items is as low as 2 secs.
this change also introduces knobs exposed via settings.properties file, which allow to show/hide the increasing number of filter and display options of calendar and timeline views.