Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user timezones in XLS documents #195

Merged
merged 9 commits into from
Jan 3, 2022
Merged

user timezones in XLS documents #195

merged 9 commits into from
Jan 3, 2022

Conversation

rkrenn
Copy link
Collaborator

@rkrenn rkrenn commented Jan 2, 2022

so far, the implementation uses the UserTimezone setting in the JSF UI layer only:

  • the database contains values in application timezone (eg. UTC)
  • forward: datetime values are converted into UserTImezone when dispalying it in the UI
  • backward: entered values are converted back from UserTimezon into application timezone

so the proper solution here is to complete the implementation:

  • implement the forward timezone conversion also in the PDF renderers
  • implement the forward timezone conversion also in the Excel renderers
  • implement the forward timezone conversion also for the rest-api response objects (to have it in the exports as desired)

this PR covers point 2. above.

the "row format" of a .xsl spreadsheet can be defined in .propertiers using a simple comma-separated list of format options, eg.

proband_list_row_format=Arial,10,false,null,true

Parameters:

  1. Font
  2. Fontsize
  3. bold?
  4. Background Color
  5. override Cell Format from the Template File (if any)?

This is now extended by 3 optional format parameters (each default to true):

  1. apply the user timezone to TimeOfDay values? (this case does not occur anywhere atm)
  2. apply the user timezone to Date values?
  3. apply the user timezone to Timestamp values?

While the eCRF data export is handled separately by the rest-api based exporter (to be able to handle huge datasets that are otherwise troublesome to keep in RAM), particular .xls exports also my include data value from EDC:

  • subject inquiry values and
  • proband list attribute values.

Like for rendered .pdf documents, the user timezone is applied to values of timestamp type only if the respective input field has the "user timezone" ceckbox checked.

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
3.8% 3.8% Duplication

@rkrenn rkrenn merged commit 2c94141 into master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant