Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Don't check version if path is present #73

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Feature: Don't check version if path is present #73

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fb29b62
Don't check version if path is present
Gigitsu Jul 25, 2024
b6a542d
Fix bolean expression
Gigitsu Jul 25, 2024
dc71e12
Fix default_version
Gigitsu Jul 25, 2024
18a07c6
Handle when bin doesn't exists
Gigitsu Jul 25, 2024
77264a8
Add `version_check` flag to explicitly disable the check
Gigitsu Aug 7, 2024
90b73d0
Minor refactor
Gigitsu Aug 7, 2024
0c65122
Add `version_check` documentation
Gigitsu Aug 7, 2024
b716dc3
Improve doc
Gigitsu Aug 7, 2024
889b2e6
Revert `:version` doc
Gigitsu Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/esbuild.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
defmodule Esbuild do
# https://registry.npmjs.org/esbuild/latest
@latest_version "0.17.11"
@latest_version "0.23.00"

@moduledoc """
Esbuild is an installer and runner for [esbuild](https://esbuild.github.io).
Expand Down Expand Up @@ -65,7 +65,7 @@ defmodule Esbuild do

@doc false
def start(_, _) do
unless Application.get_env(:esbuild, :version) do
unless Application.get_env(:esbuild, :version) or Application.get_env(:esbuild, :path) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think or will work here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed

Logger.warning("""
esbuild version is not configured. Please set it in your config files:

Expand Down Expand Up @@ -100,7 +100,10 @@ defmodule Esbuild do
Returns the configured esbuild version.
"""
def configured_version do
Application.get_env(:esbuild, :version, latest_version())
default_version =
if Application.get_env(:esbuild, :path), do: bin_version(), else: latest_version()

Application.get_env(:esbuild, :version, default_version)
end

@doc """
Expand Down