Add --repo
option to schema generator
#4882
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
--repo
option to the schema generator so apps that have multiple repos can have the ability to select what repo the schema/migration should use.I noticed
ecto.gen.migration
supports this flag and assumed it would work in phoenix as well. It did not, so here it is :-)This works on the schema generator and other "parent" generators that call it (eg:
phx.gen.context
)NOTE to reviewer
Ideally, I wanted to support a custom
priv
config that may be set on the repo to determine themigration_path
, however I noticed that will require me ensuring the repo module is compiled first. I wanted to get some advice on that before doing anything.