Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default :info flash display "Info" instead, and add a :success flash with the old behaviour #5844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DitherWither
Copy link

Fixes #5795

Also use blue for the info flash, as that is what info dialogues tend to use.

Image of the info flash

@josevalim
Copy link
Member

Thank you for the PR. However, I think we should keep the generated code simple and not add a new style. We should either rename :info to :success or change the style of :info to something slightly more neutral (or keep it all as is).

@mattmatters
Copy link
Contributor

We've done something similar on a couple projects. I think the defaults are fine as they are, but some of the documentation doesn't actually make it very clear that flash types can be whatever (at least in the liveview documentation). Maybe we start with just adding a little nice clarification here for now.

@SteffenDE
Copy link
Contributor

@mattmatters the docs were already adjusted in response to phoenixframework/phoenix_live_view#3342, but that’s not released yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default :info flash is not an Info flash, it is a Success flash
4 participants