Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly validate shard blocks #113

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Properly validate shard blocks #113

wants to merge 3 commits into from

Conversation

meyer9
Copy link
Member

@meyer9 meyer9 commented Aug 4, 2020

This PR adds the following checks to shard blocks:

  • Block hash and signature must validate with the included public key in the proof.
  • Proposer index + shard must match algorithm for finding proposer index.
  • Shard block proof must hash to finalized beacon chain block ValidatorProof .

Closes #112

@meyer9 meyer9 added enhancement New feature or request beacon shard labels Aug 4, 2020
@meyer9 meyer9 self-assigned this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon enhancement New feature or request shard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shard proofs should be properly validated
2 participants