Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback requested: Refactor library for Vue v3 support #2

Merged
merged 28 commits into from
Dec 1, 2020
Merged

Commits on Nov 16, 2020

  1. Refactor library for Vue v3 support

    Wherever possible, I have kept as close to the Vue v2 code as I could,
    but I was forced to make typing judgement calls in a few places that
    should probably be double-checked.
    The only exception to the hands-off approach is in the example app,
    which I took the liberty of porting to the Vue v3 composition API since
    I'd be touching most of the LOC in it anyway.
    brlodi committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    d464eb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fd5a8e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Configuration menu
    Copy the full SHA
    a465c4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79d8583 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e50ccc3 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Refactor components to Composition API

    Partially for the conciseness, partly because it allows explicit types
    in a Vue 3 friendly way
    brlodi committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    a873c90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e89a590 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c82ff93 View commit details
    Browse the repository at this point in the history
  4. meta: bump to v1.0.1

    rektdeckard committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    4242f47 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6550b5b View commit details
    Browse the repository at this point in the history
  6. README: fix example typo

    rektdeckard committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    024aa7d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a0ba386 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Make build not error out

    The result doesn't have proper type definitions though, so it's not
    "working" per se
    brlodi committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    ffa69c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Configuration menu
    Copy the full SHA
    a30f3a2 View commit details
    Browse the repository at this point in the history
  2. lib: bump to v1.0.2

    rektdeckard committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    c4b808f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Configuration menu
    Copy the full SHA
    1ef1c0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    739b691 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23ca61c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Configuration menu
    Copy the full SHA
    88242aa View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. icons+meta: update assets and components to v1.1.2

    This patch fixes rendering bugs with icons using strokes for dot
    elements, whereby using a stroke weight larger than the circle radius
    caused unexpected clipping. We reverted to using ellipse elements for
    all cases.
    rektdeckard committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    f63f18c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Pin Vue at 3.0.2 to avoid bug in 3.0.3

    Follow vuejs/core#2687 for status
    brlodi committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    462242b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bcfc45 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdc6a18 View commit details
    Browse the repository at this point in the history
  4. Prettier run

    This is a result of specifying a Prettier version in devDeps, which uses
    a newer version of Prettier with slightly different defaults
    brlodi committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    c056172 View commit details
    Browse the repository at this point in the history
  5. Auto-generate library .d.ts file with assemble.js

    This provides the appropriate types with the built package, but
    continues to be suboptimal and super non-DRY. I haven't yet found a way
    to avoid explicitly declaring every named export, unfortunately.
    brlodi committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    d624b83 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Configuration menu
    Copy the full SHA
    003743c View commit details
    Browse the repository at this point in the history
  2. Enable tree-shaking (really it was this easy?!)

    Note: this tree-shakes, but only mostly due to Webpack 4 struggling with
    "double-barrel" structures like we have with `index.ts` and `entry.ts`.
    Importing a single icon from Phosphor-Vue is not a full 2.5MB anymore,
    but there's still a bunch of unnecessary code included (it *does* seem
    to purge the unused templates which is the bulk of the library size).
    Webpack 5 apparently handles double-barrels better, so we should see
    that problem disappear once vue-cli ships Webpack 5 support and clients
    start using it (track vuejs/vue-cli#5611)
    brlodi committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    53c10fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c808b6 View commit details
    Browse the repository at this point in the history