-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback requested: Refactor library for Vue v3 support #2
Commits on Nov 16, 2020
-
Refactor library for Vue v3 support
Wherever possible, I have kept as close to the Vue v2 code as I could, but I was forced to make typing judgement calls in a few places that should probably be double-checked. The only exception to the hands-off approach is in the example app, which I took the liberty of porting to the Vue v3 composition API since I'd be touching most of the LOC in it anyway.
Configuration menu - View commit details
-
Copy full SHA for d464eb2 - Browse repository at this point
Copy the full SHA d464eb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fd5a8e - Browse repository at this point
Copy the full SHA 0fd5a8eView commit details
Commits on Nov 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a465c4d - Browse repository at this point
Copy the full SHA a465c4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79d8583 - Browse repository at this point
Copy the full SHA 79d8583View commit details -
Configuration menu - View commit details
-
Copy full SHA for e50ccc3 - Browse repository at this point
Copy the full SHA e50ccc3View commit details
Commits on Nov 19, 2020
-
Refactor components to Composition API
Partially for the conciseness, partly because it allows explicit types in a Vue 3 friendly way
Configuration menu - View commit details
-
Copy full SHA for a873c90 - Browse repository at this point
Copy the full SHA a873c90View commit details -
Configuration menu - View commit details
-
Copy full SHA for e89a590 - Browse repository at this point
Copy the full SHA e89a590View commit details -
Configuration menu - View commit details
-
Copy full SHA for c82ff93 - Browse repository at this point
Copy the full SHA c82ff93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4242f47 - Browse repository at this point
Copy the full SHA 4242f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6550b5b - Browse repository at this point
Copy the full SHA 6550b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 024aa7d - Browse repository at this point
Copy the full SHA 024aa7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ba386 - Browse repository at this point
Copy the full SHA a0ba386View commit details
Commits on Nov 20, 2020
-
The result doesn't have proper type definitions though, so it's not "working" per se
Configuration menu - View commit details
-
Copy full SHA for ffa69c1 - Browse repository at this point
Copy the full SHA ffa69c1View commit details
Commits on Nov 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a30f3a2 - Browse repository at this point
Copy the full SHA a30f3a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4b808f - Browse repository at this point
Copy the full SHA c4b808fView commit details
Commits on Nov 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1ef1c0f - Browse repository at this point
Copy the full SHA 1ef1c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 739b691 - Browse repository at this point
Copy the full SHA 739b691View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23ca61c - Browse repository at this point
Copy the full SHA 23ca61cView commit details
Commits on Nov 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 88242aa - Browse repository at this point
Copy the full SHA 88242aaView commit details
Commits on Nov 26, 2020
-
icons+meta: update assets and components to v1.1.2
This patch fixes rendering bugs with icons using strokes for dot elements, whereby using a stroke weight larger than the circle radius caused unexpected clipping. We reverted to using ellipse elements for all cases.
Configuration menu - View commit details
-
Copy full SHA for f63f18c - Browse repository at this point
Copy the full SHA f63f18cView commit details
Commits on Nov 30, 2020
-
Pin Vue at 3.0.2 to avoid bug in 3.0.3
Follow vuejs/core#2687 for status
Configuration menu - View commit details
-
Copy full SHA for 462242b - Browse repository at this point
Copy the full SHA 462242bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bcfc45 - Browse repository at this point
Copy the full SHA 4bcfc45View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc6a18 - Browse repository at this point
Copy the full SHA bdc6a18View commit details -
This is a result of specifying a Prettier version in devDeps, which uses a newer version of Prettier with slightly different defaults
Configuration menu - View commit details
-
Copy full SHA for c056172 - Browse repository at this point
Copy the full SHA c056172View commit details -
Auto-generate library .d.ts file with assemble.js
This provides the appropriate types with the built package, but continues to be suboptimal and super non-DRY. I haven't yet found a way to avoid explicitly declaring every named export, unfortunately.
Configuration menu - View commit details
-
Copy full SHA for d624b83 - Browse repository at this point
Copy the full SHA d624b83View commit details
Commits on Dec 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 003743c - Browse repository at this point
Copy the full SHA 003743cView commit details -
Enable tree-shaking (really it was this easy?!)
Note: this tree-shakes, but only mostly due to Webpack 4 struggling with "double-barrel" structures like we have with `index.ts` and `entry.ts`. Importing a single icon from Phosphor-Vue is not a full 2.5MB anymore, but there's still a bunch of unnecessary code included (it *does* seem to purge the unused templates which is the bulk of the library size). Webpack 5 apparently handles double-barrels better, so we should see that problem disappear once vue-cli ships Webpack 5 support and clients start using it (track vuejs/vue-cli#5611)
Configuration menu - View commit details
-
Copy full SHA for 53c10fd - Browse repository at this point
Copy the full SHA 53c10fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c808b6 - Browse repository at this point
Copy the full SHA 6c808b6View commit details