This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Update to Bootstrap v5 - Additional Changes #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkh
suggested changes
Aug 1, 2021
There was a problem hiding this comment.
Thanks for your work! In general it looks good. I still found a small bug in the provenance side panel.
Steps to reproduce
- Open the provenance graph
- Select Authoring mode in the header
- Open the filter toolbar in the provenance side panel
- Open tags dropdown
Observed behavior
Expected behavior
- Dropdown should be on top of the authoring side panel
- The dropdown button should be the same as the other filter buuton
Thanks for your review! It should be fixed now. 👍 |
thinkh
approved these changes
Aug 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/datavisyn/visyn2025/issues/80