#1229 Allow return null in kafka Serializer (delete messages aka Tomb…

…stone)
php-enqueue · Jan 11, 2022 · 09afec8 · 09afec8
1 parent 66f15d0
commit 09afec8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 17 deletions.
diff --git a/pkg/rdkafka/JsonSerializer.php b/pkg/rdkafka/JsonSerializer.php
@@ -6,34 +6,30 @@
 
 class JsonSerializer implements Serializer
 {
-    public function toString(RdKafkaMessage $message): string
+    public function toString(RdKafkaMessage $message): ?string
     {
         $json = json_encode([
             'body' => $message->getBody(),
             'properties' => $message->getProperties(),
             'headers' => $message->getHeaders(),
         ]);
 
-        if (JSON_ERROR_NONE !== json_last_error()) {
-            throw new \InvalidArgumentException(sprintf(
-                'The malformed json given. Error %s and message %s',
-                json_last_error(),
-                json_last_error_msg()
-            ));
+        if (\JSON_ERROR_NONE !== json_last_error()) {
+            throw new \InvalidArgumentException(sprintf('The malformed json given. Error %s and message %s', json_last_error(), json_last_error_msg()));
         }
 
         return $json;
     }
 
-    public function toMessage(string $string): RdKafkaMessage
+    public function toMessage(?string $string): RdKafkaMessage
     {
-        $data = json_decode($string, true);
-        if (JSON_ERROR_NONE !== json_last_error()) {
-            throw new \InvalidArgumentException(sprintf(
-                'The malformed json given. Error %s and message %s',
-                json_last_error(),
-                json_last_error_msg()
-            ));
+        if (null !== $string) {
+            $data = json_decode($string, true);
+            if (\JSON_ERROR_NONE !== json_last_error()) {
+                throw new \InvalidArgumentException(sprintf('The malformed json given. Error %s and message %s', json_last_error(), json_last_error_msg()));
+            }
+        } else {
+            $data = ['body' => null, 'properties' => null, 'headers' => 'headers'];
         }
 
         return new RdKafkaMessage($data['body'], $data['properties'], $data['headers']);

diff --git a/pkg/rdkafka/Serializer.php b/pkg/rdkafka/Serializer.php
@@ -6,7 +6,7 @@
 
 interface Serializer
 {
-    public function toString(RdKafkaMessage $message): string;
+    public function toString(RdKafkaMessage $message): ?string;
 
-    public function toMessage(string $string): RdKafkaMessage;
+    public function toMessage(?string $string): RdKafkaMessage;
 }