[bundle] Remove any config options.

php-enqueue · Jan 18, 2018 · 766968e · 766968e
1 parent 262142a
commit 766968e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/pkg/enqueue/Symfony/MissingTransportFactory.php b/pkg/enqueue/Symfony/MissingTransportFactory.php
@@ -47,9 +47,16 @@ public function addConfiguration(ArrayNodeDefinition $builder)
 
         $builder
             ->info($message)
-            ->validate()->always(function () use ($message) {
-                throw new \InvalidArgumentException($message);
-            })
+            ->beforeNormalization()
+                ->always(function () {
+                    return [];
+                })
+                ->end()
+            ->validate()
+                ->always(function () use ($message) {
+                    throw new \InvalidArgumentException($message);
+                })
+                ->end()
         ;
     }
 

diff --git a/pkg/enqueue/Tests/Symfony/MissingTransportFactoryTest.php b/pkg/enqueue/Tests/Symfony/MissingTransportFactoryTest.php
@@ -53,4 +53,21 @@ public function testThrowOnProcessForSeveralPackagesToInstall()
         $this->expectExceptionMessage('Invalid configuration for path "foo": In order to use the transport "aMissingTransportName" install one of the packages "aFooPackage", "aBarPackage"');
         $processor->process($tb->buildTree(), [[]]);
     }
+
+    public function testThrowEvenIfThereAreSomeOptionsPassed()
+    {
+        $transport = new MissingTransportFactory('aMissingTransportName', ['aFooPackage', 'aBarPackage']);
+        $tb = new TreeBuilder();
+        $rootNode = $tb->root('foo');
+
+        $transport->addConfiguration($rootNode);
+        $processor = new Processor();
+
+        $this->expectException(InvalidConfigurationException::class);
+        $this->expectExceptionMessage('In order to use the transport "aMissingTransportName"');
+        $processor->process($tb->buildTree(), [[
+            'foo' => 'fooVal',
+            'bar' => 'barVal',
+        ]]);
+    }
 }