fix: allow absolute paths for sqlite transport #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a better approach to the issue. Could you consider using Dsn class? Check the example https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/fs/FsConnectionFactory.php#L73 That would be great if you could add some tests too. |
|
Oh great, I didn't check the other transport implementations, but this looks like a cleaner approach. I will update the PR accordingly. |
makasim
reviewed
Jan 29, 2020
|
Do you have more ideas for improving this PR? Or can it be merged? |
|
All is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when switching from
amqp+libtosqlite3transport, we were not able to setup DSNs with absolute paths. It seems thatparse_url()only allows more than 2 slashes forfile:scheme and fails for other schemes (see Notes in the documentation). SQLite however happily uses 3 and more slashes for DSNs.This PR proposes a special handling for
sqlite:scheme and fixes #780. Relevant changes are lines 100-103, the rest is php-cs-fixer.