Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Add automatic reconnect support for STOMP producers #1099

Merged
merged 11 commits into from
Oct 8, 2020
Merged

Fix - Add automatic reconnect support for STOMP producers #1099

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b09cecb
Add automatic reconnect support for STOMP producers.
atrauzzi Sep 29, 2020
bfd08b1
Not sure why lock got ignored...
atrauzzi Sep 29, 2020
b4afec2
Do we not want this?
atrauzzi Sep 30, 2020
2a0545c
Fix for stomp-php - Use one connection for each message.
atrauzzi Sep 30, 2020
a439f00
Unfortunately, can't use this as it will break actual long-lived conn…
atrauzzi Sep 30, 2020
cd3c765
Allow connections that have no consumer to be considered 'transient'.
atrauzzi Oct 1, 2020
905b3e8
Revert StompProducer
atrauzzi Oct 1, 2020
327ca4d
Amend test.
atrauzzi Oct 1, 2020
36d4e01
Allow the detection of transient connections to be configured.
atrauzzi Oct 8, 2020
2e1d06d
Add default configuration for transient connection detection.
atrauzzi Oct 8, 2020
b46a945
Update configuration for tests.
atrauzzi Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ bin/jp.php
bin/php-parse
bin/google-cloud-batch
bin/thruway
bin/phpstan.phar
bin/var-dump-server
bin/yaml-lint
vendor
var
.php_cs
.php_cs.cache
composer.lock
composer.lock
14 changes: 13 additions & 1 deletion pkg/stomp/StompProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Interop\Queue\Message;
use Interop\Queue\Producer;
use Stomp\Client;
use Stomp\Exception\ConnectionException;
use Stomp\Transport\Message as StompLibMessage;

class StompProducer implements Producer
Expand Down Expand Up @@ -39,7 +40,18 @@ public function send(Destination $destination, Message $message): void

$stompMessage = new StompLibMessage($message->getBody(), $headers);

$this->stomp->send($destination->getQueueName(), $stompMessage);
try {
$this->stomp->send($destination->getQueueName(), $stompMessage);
} catch (ConnectionException $ex) {
if (!$this->stomp->isConnected()) {
atrauzzi marked this conversation as resolved.
Show resolved Hide resolved
throw $ex;
}

$this->stomp->disconnect(true);
$this->stomp->connect();

$this->stomp->send($destination->getQueueName(), $stompMessage);
}
}

/**
Expand Down