[sns] added possibility to define already existing topics (prevent create topic call) #1022 #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Mar 18, 2021
pkg/sns/SnsContext.php
Outdated
| { | ||
| $this->client = $client; | ||
| $this->config = $config; | ||
|
|
||
| $this->topicArns = []; | ||
| $this->topicArns = $topicArns; |
There was a problem hiding this comment.
topicArns property format is
topic_name => arn
makasim
reviewed
Mar 18, 2021
pkg/sns/SnsConnectionFactory.php
Outdated
| @@ -71,7 +72,7 @@ public function __construct($config = 'sns:') | |||
| */ | |||
| public function createContext(): Context | |||
| { | |||
| return new SnsContext($this->establishConnection(), $this->config); | |||
| return new SnsContext($this->establishConnection(), $this->config, $this->config['topic_arns']); | |||
There was a problem hiding this comment.
why do you pass topc_arns as separate arg? They are already there in config which is passed as second arg
makasim
reviewed
Mar 18, 2021
pkg/sns/SnsConnectionFactory.php
Outdated
| @@ -59,6 +60,9 @@ public function __construct($config = 'sns:') | |||
|
|
|||
| unset($config['dsn']); | |||
| } | |||
| if (\array_key_exists('topic_arns', $config) && \is_string($config['topic_arns'])) { | |||
There was a problem hiding this comment.
at this stage it has to be assoc array already. The string parsing should happen if dsn is passed.
There was a problem hiding this comment.
removed, not needed when using dsn parsing
makasim
reviewed
Mar 18, 2021
| ]; | ||
|
|
||
| yield [ | ||
| ['dsn' => 'sns:?topic_arns=topic1|arn:aws:sns:us-east-1:123456789012:topic1;topic2|arn:aws:sns:us-west-2:123456789012:topic2'], |
There was a problem hiding this comment.
what about passing arns as
topic_arns[topic1]=arn:aws:sns:us-east-1:123456789012&topic_arns[topic2]=arn:aws:sns:us-west-2:123456789012:topic2
that way the standard query parsing function does the job
makasim
reviewed
Mar 18, 2021
|
fixes #1022 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.