-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony 6; drop < 5.1 #1239
Conversation
andrewmy
commented
Feb 10, 2022
•
edited
Loading
edited
- Allow Symfony 6 in composer deps
- Add Symfony 6 to the build matrix only for PHP 8
- Bump min php-cs-fixer to ^3.4 to allow symfony/console 6, update its config
- Bump min psr/log to 1.1
- Add TestLogger from psr/log:1 because it's removed from 2 and 3
- Fix Event Dispatcher compatibility for async events which happened to use a deprecated dispatcher configuration method
- Drop Symfony older than 5.1
❤️ the commit history 😅 |
Currently investigating the issue with async event listeners being registered twice — either an issue with the fixture app, or Sf 6 🤔 |
@makasim take a look pls. Squashed everything to avoid letting all this commit message nonsense into master ;) |
I see some juggling with event dispatcher. |
@andrewmy thank you for the great work! |
The new dispatcher thing was introduced in 5.1, so dropping means a bit wider scope. I'm not against it, your call :) |
Let's keep it simple. Could you set "symfony/xxx": "^5.1|^6" |
If it means a new major release, then we could include #1230 in it. |
@Steveb-p bumping minimum deps can happen in a patch version as long as the external API is unchanged. |
Used this opportunity to burn down whatever I found regarding the < 5 BC layer. There's still the thing about one different line in fixture apps — session. Looks ugly but not warranting instant drop of anything < 5.4 I guess. |
Nah, it's a hell of a lot of work. just an ordinary release. |
LGTM, could be merged? |
Yes please, with a pretty tag on top 🙏 |
Could we have a release? :) |