Drop useless call to end method

[ddziaduch]

Due to this, upgrading from SF 6.4.7 to more recent versions is impossible.

Output from the cache:clear after upgrade:

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  TypeError {#5946
!!    #message: "Symfony\Component\Config\Definition\Builder\NodeDefinition::end(): Return value must be of type Symfony\Component\Config\Definition\Builder\NodeParentInterface, null returned"
!!    #code: 0
!!    #file: "./vendor/symfony/config/Definition/Builder/NodeDefinition.php"
!!    #line: 98
!!    trace: {
!!      ./vendor/symfony/config/Definition/Builder/NodeDefinition.php:98 { …}
!!      ./vendor/enqueue/enqueue/Symfony/Client/DependencyInjection/ClientFactory.php:82 { …}
!!      ./vendor/enqueue/enqueue-bundle/DependencyInjection/Configuration.php:42 { …}
!!      ./vendor/symfony/config/Definition/Processor.php:46 { …}
!!      ./vendor/symfony/dependency-injection/Extension/Extension.php:109 { …}
!!      ./vendor/enqueue/enqueue-bundle/DependencyInjection/EnqueueExtension.php:34 { …}
!!      ./vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php:76 { …}
!!      ./vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php:42 { …}
!!      ./vendor/symfony/dependency-injection/Compiler/Compiler.php:80 { …}
!!      ./vendor/symfony/dependency-injection/ContainerBuilder.php:767 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:506 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:771 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:126 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:190 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:72 { …}
!!      ./vendor/symfony/console/Application.php:175 { …}
!!      ./bin/console:43 {
!!        › $application = new Application($kernel);
!!        › $application->run($input);
!!        › 
!!      }
!!    }
!!  }
!!  2024-09-17T12:45:24+00:00 [critical] Uncaught Error: Symfony\Component\Config\Definition\Builder\NodeDefinition::end(): Return value must be of type Symfony\Component\Config\Definition\Builder\NodeParentInterface, null returned
!!  
Script @auto-scripts was called via post-install-cmd

[ddziaduch]

@makasim @p-pichet can this be merged? It is quite important for us

[makasim]

sorry, I might be missing something. What has been changed, except for indentions?

[ddziaduch]

@makasim at the end of the method there were three calls to end() method, now there are just two - the last was unnecessary

[Steveb-p]

The change is correct.

We accidentally went and called Node::end() one additional time. Because there is no node above (which is what end method gives) it started failing once this method became strong-typed in Symfony.

In theory there is no need to call end() method at all, if we're not interested in traversing the tree. But it is done across all Symfony examples and is otherwise safe to do.

[p-pichet]

Base on the explanation, it's ok for me, but can you add indentation please ?
I don't have right for merge it

[makasim]

got it, thanks!

[ddziaduch]

@makasim can you please create a new tag? Thanks in advance 🙂

[ddziaduch]

Is anybody able to help with this tag? @makasim @p-pichet @Steveb-p maybe?

[makasim]

https://github.com/php-enqueue/enqueue/releases/tag/0.10.23