Use Query Builder for better support across platforms. #176
Conversation
|
@jenkoian what platform are you going to use? |
|
FYI: It has not ever tested agains SQLite. We used it with mysql and postgresql. I'll try to find some time next week to fix #170. |
|
It looks good but could you please look at travis, it complains about something. |
|
|
|
@makasim ok will change to getWriteLockSQL |
Not all drivers supported FOR UPDATE queries so this changes changes the raw SQL to use the query builder thus allowing DBAL to construct hte appropriate query per platform. It then grabs the SQL and appends the read lock SQL but grabs the SQL part from the correct platform thus as to not break portability.
|
@makasim updated to use getReadLockSQL and ran the cs fixer to hopefully fix the build. |
|
@makasim the remaining build failure seem to be SQS related, possibly to do with this warning? |
|
@jenkoian that ok. travis does not add secret envs to a build if a build is initialized by a not authorized person. |
Use Query Builder for better support across platforms.
Not all drivers supported FOR UPDATE queries so this change changes the
raw SQL to use the query builder thus allowing DBAL to construct the
appropriate query per platform. It then grabs the SQL and appends the
read lock SQL but grabs the SQL part from the correct platform as
to not break portability.