Fix reversed logic for native UUID detection #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Dec 19, 2017
pkg/dbal/DbalContext.php
Outdated
| @@ -170,7 +170,7 @@ public function createDataBaseTable() | |||
| return; | |||
| } | |||
|
|
|||
| if ($this->getDbalConnection()->getDatabasePlatform()->hasNativeGuidType()) { | |||
| if (!$this->getDbalConnection()->getDatabasePlatform()->hasNativeGuidType()) { | |||
There was a problem hiding this comment.
I guess this change would break MySql. Could you remove it?
There was a problem hiding this comment.
I have removed the check. That check should not be necessary in the first place because Doctrine will use the UUID column type if available, otherwise fall back to VARCHAR. One thing to take note of is that it may be necessary to add some code to #280 to detect and migrate the column type if you decide to merge that PR.
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
Fix reversed logic for native UUID detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that you are working on #280 but for current users of Enqueue, it is very inconvenient to manually edit the package to fix this bug and it also makes deploying/CI difficult. Can you release this as 0.8.12?