fix fsdriver router topic name #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendavies
force-pushed
the
fix-router-topic-name
branch
from
4334b16 to
c10f0de
Compare
makasim
reviewed
Mar 30, 2017
pkg/enqueue/Client/Config.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| private function getQueueName($name) |
There was a problem hiding this comment.
Could you please rename it to getDestinationName
bendavies
force-pushed
the
fix-router-topic-name
branch
from
c10f0de to
7a5d2f0
Compare
|
I have just realized that the router topic must not contain an app it. The router topic is a shared one. Several applications may send messages to it and hence talk to each other. It is a ground part of message bus support. And since message bus is not supported by |
|
no problem, i'll take a look. |
bendavies
force-pushed
the
fix-router-topic-name
branch
from
7a5d2f0 to
d91cc99
Compare
|
@bendavies yeap that looks good. |
|
@makasim i'll add a test to cover this case. |
bendavies
force-pushed
the
fix-router-topic-name
branch
from
d91cc99 to
93b18b2
Compare
|
@makasim done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in gitter.