Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order by publish_date within priorities #362

Closed
wants to merge 1 commit into from
Closed

Order by publish_date within priorities #362

wants to merge 1 commit into from

Conversation

Gugiman
Copy link
Contributor

@Gugiman Gugiman commented Feb 8, 2018

When multiple messages got the same priority they should nevertheless be ordered by publish date

@makasim
Copy link
Member

makasim commented Feb 8, 2018

Could you please fix failed tests and add a func test that covers this case?

@makasim
Copy link
Member

makasim commented Feb 9, 2018

@Gugiman Could you please rebase against the latest master.

@Gugiman
Copy link
Contributor Author

Gugiman commented Feb 9, 2018

Is up-to-date

Unfortunately I'm not familiar with using and writing unit tests.

@Gugiman
Copy link
Contributor Author

Gugiman commented Feb 13, 2018

Travis error seems to still exist even without my change.

@makasim
Copy link
Member

makasim commented Feb 14, 2018

close in favor #371

@makasim makasim closed this Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants