WIP: Add support for using a pre-configured client with the SQS driver #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
May 14, 2018
| @@ -38,7 +39,9 @@ class SqsConnectionFactory implements PsrConnectionFactory | |||
| */ | |||
| public function __construct($config = 'sqs:') | |||
There was a problem hiding this comment.
I think the constructor should accept an instance of Client, no need to pass it as an array parameter. We would not be able to apply other options in the array in any case.
There was a problem hiding this comment.
The symfony transport should have it as a client option though
|
@makasim Any suggestions on what I might be doing wrong with the bundle configuration change? |
|
@elazar I've not spotted anything suspicion, gonna take a closer look later. |
@makasim Bump. 😉 |
dbrumann
reviewed
Jul 7, 2018
| @@ -34,6 +34,7 @@ public function addConfiguration(ArrayNodeDefinition $builder) | |||
| { | |||
| $builder | |||
| ->children() | |||
| ->scalarNode('client')->defaultNull()->end() | |||
There was a problem hiding this comment.
I would expect there to be something like the following in createConnectionFactory() below:
if (false == empty($config['client'])) {
$config['client'] = new Reference($config['client']);
}
Use client defined in configuration in SqsConnectionFactory
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
…ient WIP: Add support for using a pre-configured client with the SQS driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress and relates to #443.
Many thanks to @rpkamp and @dbrumann for their assistance!