Job Queue: Throw orphan job exception when child job cleanup fails. #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
Job Queue: Throw orphan job exception when child job cleanup fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the callback sent to
JobRunner::runUnique()triggers a database exception the entity manager is closed. ThenJobProcessor::failChildJob()attempts to use the closed manager and throws another exception. This latest exception stops execution before the original exception can be thrown, masking it.This change fixes the immediate issue of not being able to see the runUnique callback error by catching job cleanup failures and throwing the new
OrphanJobExceptionwith previous exception. Going further,OrphanJobExceptioncould be caught to trigger alternative job cleanup strategies.