Allow either subscribe or assign in RdKafkaConsumer #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `assign` it is not possible to use the rebalancing from Kafka. So if no offset is set we use `subscribe` and rebalancing is possible and otherwise if a offset is set we are using assign.
* add test that when a offset is set we use assign
|
@Engerim LGTM, could be merged? |
This was referenced Aug 21, 2018
|
@makasim when do you plan to release this bug to stable? |
|
@mente not sure it happens in near future. I think a backport for 0.8 is a better option. |
|
Oh, i wasn't aware of release cycle. Is it coming in |
|
I was almost ready to release a stable version (3-5 days left). Now I am involved in a project development. Not sure when it happens. |
This was referenced Oct 19, 2018
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
Allow either subscribe or assign in RdKafkaConsumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
assignit is not possible to use the rebalancing from Kafka. So if no offset is set we usesubscribeand rebalancing is possible and otherwise if a offset is set we are using assign.