MongoDB Subscription Consumer feature #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
reviewed
Oct 18, 2018
pkg/mongodb/MongodbMessage.php
Outdated
| @@ -65,6 +65,22 @@ public function __construct(string $body = '', array $properties = [], array $he | |||
| $this->redelivered = false; | |||
| } | |||
|
|
|||
| public static function fromArrayDbResult(array $arrayResult): self | |||
There was a problem hiding this comment.
move the method to the context, make it public with @internal docblock, look at AMQP cotext
makasim
reviewed
Oct 18, 2018
pkg/mongodb/MongodbContext.php
Outdated
| */ | ||
| public function convertMessage(array $mongodbMessage): MongodbMessage | ||
| { | ||
| $mongodbMessageObj = new MongodbMessage( |
|
could you please also update the transport doc like this one https://github.com/php-enqueue/enqueue-dev/blob/master/docs/transport/amqp.md#subscription-consumer |
rosamarsky
force-pushed
the
mongodb-subscription-consumer
branch
from
8009b56 to
d049817
Compare
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
MongoDB Subscription Consumer feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.