Fix TreeBuilder in Symfony 4.2 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
angelsk
commented
Dec 14, 2018
|
No idea why a test I didn't touch is failing. Any help would be appreciated |
@angelsk It has nothing to do with your changes. Ping when the PR is ready (no matter green or red) and I'll merge it. I'll fix that issue in another PR. This one should not wait for it though |
|
@makasim Ping :) Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.