Multi Transport Simple Client #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good to me. Could you please create a new package for the simple client ( we can call it |
|
Add other factories and move tests that depends on simple client where appropriate |
makasim
reviewed
May 10, 2017
| @@ -21,7 +21,8 @@ | |||
| "symfony/dependency-injection": "^2.8|^3", | |||
| "symfony/config": "^2.8|^3", | |||
| "enqueue/null": "^0.3", | |||
| "enqueue/test": "^0.3" | |||
| "enqueue/test": "^0.3", | |||
| "enqueue/simple-client": "^0.3" | |||
There was a problem hiding this comment.
IMO enqueue should not require simple client. Why do you think we should do?
makasim
reviewed
May 10, 2017
pkg/simple-client/LICENSE
Outdated
| @@ -0,0 +1,19 @@ | |||
| Copyright (c) 2016 Kotliar Maksym | |||
makasim
reviewed
May 10, 2017
pkg/simple-client/SimpleClient.php
Outdated
| use Enqueue\Symfony\DefaultTransportFactory; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| /** | ||
| * Experimental class. Use it speedup setup process and learning but consider to switch to custom solution (build your own client). | ||
| * Use it speedup setup process and learning but consider to switch to custom solution (build your own client). |
makasim
reviewed
May 10, 2017
pkg/simple-client/composer.json
Outdated
| "php": ">=5.6", | ||
| "enqueue/enqueue": "^0.3", | ||
| "symfony/dependency-injection": "^2.8|^3", | ||
| "symfony/config": "^2.8|^3" |
makasim
reviewed
May 10, 2017
pkg/simple-client/composer.json
Outdated
| "phpunit/phpunit": "~5.5", | ||
| "enqueue/test": "^0.3" | ||
| }, | ||
| "suggest": { |
There was a problem hiding this comment.
remote transport suggestions. (they are suggeted by enqueue/enqueue) lib
makasim
changed the title
|
Thank you @ASKozienko |
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
Multi Transport Simple Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.