Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple-client] Fix Logger Initialisation #752

Merged
merged 2 commits into from
Feb 2, 2019

Conversation

ajbonner
Copy link
Contributor

@ajbonner ajbonner commented Feb 1, 2019

When instantiating a SimpleClient, the internal dependencies are initialised before the LoggerInterface passed into SimpleClient is assigned. The effect of this is that dependent objects receive a NullLogger instead.

If the logger isn't assigned in the SimpleClient's constructor before the
object graph is initialised, dependencies will get a NullLogger rather than
the LoggerInterface passed in.
@makasim makasim changed the title Fix Logger Initialisation [simple-client] Fix Logger Initialisation Feb 2, 2019
@makasim makasim merged commit e07108d into php-enqueue:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants