DBAL Change ParameterType class to Type class #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctrine DBAL version 2.6 not have ParameterType class.
|
We have to maintain BC to previous versions, at least until they are deprecated / stop being commonly used. So we will probably have to either check against class existence via EDIT: Nvm, I'm blind. You can use DBAL Types classes in previous versions as well. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine DBAL version 2.6 does not have ParameterType class.
and the library supports version 2.6 of Doctrine DBAL.
Hope it will be merge soon.
Thanks.