#984 Symfony 4.4 compatibility #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
approved these changes
Nov 22, 2019
DamienHarper
suggested changes
Nov 22, 2019
There was a problem hiding this comment.
You should use Doctrine\Common\Persistence\ManagerRegistry instead of https://github.com/doctrine/DoctrineBundle/blob/master/UPGRADE-2.0.md#service-aliases
| @@ -2,16 +2,16 @@ | |||
|
|
|||
| namespace Enqueue\Doctrine; | |||
|
|
|||
| use Doctrine\Bundle\DoctrineBundle\Registry; | |||
There was a problem hiding this comment.
You should use Doctrine\Common\Persistence\ManagerRegistry instead as noted in the upgrade doc
There was a problem hiding this comment.
updated to ManagerRegistry
ctrl-f5
force-pushed
the
984-symfony-4-4
branch
from
32d2c07 to
fca4b3b
Compare
DamienHarper
approved these changes
Nov 25, 2019
|
any ETA on this to be merged? |
As mentioned in #988 it should be soon, probably tomorrow. In the meantime you can use the workaround described there to see if it will work in your project and maybe spot any issues. |
|
I'll close this one since it's been superseded by #988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fox issue #984 and Symfony 4.4 compatibility
see symfony/symfony#32394