Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for template renderer #1280

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add proposal for template renderer #1280

wants to merge 7 commits into from

Commits on May 30, 2022

  1. Add proposal for template renderer

    @alexander-schranz
    alexander-schranz committed May 30, 2022
    Configuration menu
    Copy the full SHA
    e568a17 View commit details
    Browse the repository at this point in the history

  2. Fix space before end of sentence

    @alexander-schranz
    alexander-schranz committed May 30, 2022
    Configuration menu
    Copy the full SHA
    ca5ff57 View commit details
    Browse the repository at this point in the history

  3. Add line about that template renderer should never stream something

    @alexander-schranz
    alexander-schranz committed May 30, 2022
    Configuration menu
    Copy the full SHA
    fbbd629 View commit details
    Browse the repository at this point in the history

  4. Add line about context shall not be an object

    @alexander-schranz
    alexander-schranz committed May 30, 2022
    Configuration menu
    Copy the full SHA
    f0e55b3 View commit details
    Browse the repository at this point in the history

  5. Add hint about context being object for implementor but required arra… 

    …y for user
    @alexander-schranz
    alexander-schranz authored May 30, 2022
    Configuration menu
    Copy the full SHA
    09a9637 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
    @alexander-schranz @samdark
    alexander-schranz and samdark authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f62eafa View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
    @alexander-schranz @vjik
    alexander-schranz and vjik authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    970939f View commit details
    Browse the repository at this point in the history