fix: Include the example of using the shortform of a closure #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explains the use of "spaces" around `fn ()`
…entheses due to directly instantiating This change aligns the required use of parentheses as mentioned in chapter `4. Classes, Properties, and Methods`: > When instantiating a new class, parentheses MUST always be present even when there are no arguments passed to the constructor.
|
I'm sorry, but we can't amend PSR-12 like this, it would have to go through an errata: https://www.php-fig.org/bylaws/psr-amendments/ At the same time, we're already working on https://github.com/php-fig/per-coding-style/, which is a natural successor of PSR-12. You should direct this suggestion there. /cc @KorvinSzanto @Crell |
fruitl00p
added a commit
to fruitl00p/per-coding-style
that referenced
this pull request
Jun 23, 2022
… classes) According to chapter 4: > ## 4. Classes, Properties, and Methods > > The term "class" refers to all classes, interfaces, and traits. > > Any closing brace MUST NOT be followed by any comment or statement on the same line. > > When instantiating a new class, parentheses MUST always be present even when there are no arguments passed to the constructor. This MR updates the spec to adhere to that rule on anonymous classes too. (taken from moved from php-fig/fig-standards#1283 but also builds upon php-fig#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains the use of "spaces" around
fn ()