Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add First Class Closure rules #27

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Add First Class Closure rules #27

merged 1 commit into from
Aug 2, 2022

Conversation

Crell
Copy link
Collaborator

@Crell Crell commented Jul 8, 2022

Not much else to say here. It's pretty basic, and that's a good thing.

@Crell Crell mentioned this pull request Jul 8, 2022
25 tasks
@KorvinSzanto
Copy link
Contributor

This looks good to me, I can't help but feel like this belongs in the operators section but I don't really know that the ... here would be an operator.

@Crell
Copy link
Collaborator Author

Crell commented Jul 18, 2022

It's not really an operator. It's really its own "thing". If anything, it's an oddball function call syntax, so I suppose it could go there? I put it in the closures section, but thinking about it, putting it in the function invocation section could make more sense.

@Crell
Copy link
Collaborator Author

Crell commented Jul 19, 2022

Rebased, and moved to the function/method section. A different subsection order may be better, but I didn't want to move too many existing sections. I defer to the Editor on that question.

@kenguest
Copy link
Contributor

kenguest commented Jul 28, 2022

Just to tighten up the text, perhaps "The correct format is foo(...)." would suffice? (Removing the 'That is,' preface.)

@Crell
Copy link
Collaborator Author

Crell commented Jul 31, 2022

It feels like it flows better to me with the connecting clause, but if @KorvinSzanto would favor without it I won't take offense. :-)

@KorvinSzanto KorvinSzanto merged commit 4a25fb1 into php-fig:master Aug 2, 2022
@KorvinSzanto
Copy link
Contributor

I prefer it without but I prefer to do the finer editing once the entire doc is closer to being ready so we can try to get a common voice.

@Crell Crell deleted the fcc branch February 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants