Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe named arguments. #42

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Describe named arguments. #42

merged 2 commits into from
Nov 10, 2022

Conversation

Crell
Copy link
Collaborator

@Crell Crell commented Sep 12, 2022 •
edited
Loading

  1. Change "arguments" to "parameters" when describing the function definition. An argument is what is passed to a parameter.
  2. Add a note about named args to the "calls" section.

Ignore previous description, I was dumb. 😄

@Crell Crell mentioned this pull request Sep 12, 2022
Closed
25 tasks
vjik
vjik reviewed Sep 17, 2022
View reviewed changes
spec.md
@@ -513,12 +513,12 @@ function fooBarBaz($arg1, &$arg2, $arg3 = [])
}
```

### 4.5 Method and Function Arguments
### 4.5 Method and Function Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here describe arguments and parameters both. In PHP used caption Function arguments. May be in PER save caption "Method and Function Arguments" also?

@KorvinSzanto KorvinSzanto merged commit cd79134 into php-fig:master Nov 10, 2022
@Crell Crell deleted the named-args branch November 11, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik left review comments

@samdark samdark samdark approved these changes

@func0der func0der func0der approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Crell @samdark @vjik @func0der @KorvinSzanto