Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Mock strategy to work for async clients too #137

Merged
merged 2 commits into from
Feb 23, 2019
Merged

Fix the Mock strategy to work for async clients too #137

merged 2 commits into from
Feb 23, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 22, 2019 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets no
License MIT

What's in this PR?

This PR makes the Mock client discoverable as an async client too.

Why?

I need it in getsentry/sentry-php#777 to avoid using a real client while testing the autodiscovery process.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

@Jean85 Jean85 force-pushed the fix-mock-discovery branch from 8aab76c to f6973e5 Compare February 22, 2019 23:17
dbu
dbu approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, was not aware we missed that! i will do a patch release with this, i consider it a bug. mock comes last, so i can't see this affecting production systems.

@dbu dbu merged commit 9551d26 into php-http:master Feb 23, 2019
@Jean85 Jean85 deleted the fix-mock-discovery branch February 24, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jean85 @dbu